Skip to content

Package updates - #853

Merged
dmt0 merged 17 commits into
masterfrom
package-upgrades-201902
Mar 4, 2019
Merged

Package updates#853
dmt0 merged 17 commits into
masterfrom
package-upgrades-201902

Conversation

@dmt0

@dmt0 dmt0 commented Feb 25, 2019

Copy link
Copy Markdown
Contributor

Closes #245
Closes #585

@dmt0
dmt0 force-pushed the package-upgrades-201902 branch 11 times, most recently from 8dca550 to 2a7e573 Compare February 27, 2019 22:03
@dmt0 dmt0 mentioned this pull request Feb 27, 2019
@dmt0
dmt0 force-pushed the package-upgrades-201902 branch 5 times, most recently from 481e942 to 215f546 Compare February 28, 2019 21:29
@dmt0

dmt0 commented Mar 1, 2019

Copy link
Copy Markdown
Contributor Author

@VeraZab @nicolaskruchten Ready for review commit by commit

Comment thread src/components/containers/ModalProvider.js
Comment thread src/EditorControls.js
Comment thread src/components/fields/DataSelector.js
Comment thread src/components/fields/Dropdown.js
Comment thread src/components/fields/DropdownCustom.js
Comment thread src/components/fields/FontSelector.js
Comment thread src/components/fields/LineSelectors.js
Comment thread src/components/widgets/Dropdown.js
Comment thread src/components/widgets/Dropdown.js
Comment thread src/components/widgets/Dropdown.js
Comment thread src/styles/components/widgets/_dropdown.scss Outdated
Comment thread src/lib/striptags.js
Comment thread .eslintrc
Comment thread README.md
@VeraZab

VeraZab commented Mar 4, 2019

Copy link
Copy Markdown
Contributor

yeah, mainly have a concern about those optionRenderer, and valueRenderer props we've removed..

@bpostlethwaite, would be nice to have your input here, maybe we could have a quick Slack chat about this, do you think its alright to remove those 2 props from our api..?

@dmt0

dmt0 commented Mar 4, 2019

Copy link
Copy Markdown
Contributor Author

Regarding the removed props. They were now replaced in EditorControls with this:
dataSourceComponents: PropTypes.object,
It gives us the same functionality, through a different mechanism though.
The props are not mentioned in the readme, but our version bump should include something like this:

Breaking change:
dataSourceValueRenderer and dataSourceOptionRenderer props in EditorControls have been replaced with a new prop dataSourceComponents. See the upgrade guide here: https://react-select.com/upgrade-guide#new-components-api

@dmt0
dmt0 force-pushed the package-upgrades-201902 branch from acf363f to e81c20d Compare March 4, 2019 19:31
@bpostlethwaite

Copy link
Copy Markdown
Member

Yes we can remove those from our API, documented in the Changelog of course. Thanks for bringing this to my attention!

Comment thread src/styles/components/widgets/_dropdown.scss
@VeraZab

VeraZab commented Mar 4, 2019

Copy link
Copy Markdown
Contributor

ok, well 💃 from me!

@dmt0
dmt0 merged commit 3ba9d33 into master Mar 4, 2019
@dmt0
dmt0 deleted the package-upgrades-201902 branch March 4, 2019 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants